Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
booth_checker/__main__.py
Outdated
| if response.status_code != 200: | ||
| logger.error(f'BOOTH heartbeat failed: {e}. Skipping this cycle.') | ||
| sleep(refresh_interval) |
There was a problem hiding this comment.
When the BOOTH heartbeat returns a non-200 response, the code logs f'BOOTH heartbeat failed: {e}...' even though e is never defined in this branch. Any non-200 reply will therefore raise a NameError and crash the cycle instead of skipping it, defeating the intended error handling.
Useful? React with 👍 / 👎.
booth_checker/__main__.py
Outdated
| logger.info('Checking BOOTH heartbeat') | ||
| response = requests.get("https://booth.pm", timeout=10) | ||
|
|
||
| if response.status_code != 200: | ||
| logger.error(f'BOOTH heartbeat failed: {e}. Skipping this cycle.') |
There was a problem hiding this comment.
The BOOTH heartbeat call is no longer wrapped in a try/except. Any requests exception (e.g., temporary DNS failure or connection timeout) will now propagate and kill the infinite loop, whereas the surrounding log messages and earlier implementation were intended to log the error and skip the cycle. This regression makes the monitor brittle to transient network errors.
Useful? React with 👍 / 👎.
|
PR Close 처리 |
1 participant
No description provided.